OK
Pages: 1 2
Rating:
7.01
Thread Listing » General AWN Discussion
[Announcement] New experimental branch awn-cairo-effects
#22625 by moonbeam (1.0000) posted on 8:57am Monday, June 16th, 2008
( no avatar )
dolfje said:
for the 3d-effect: you have to cut out the part where the icon is facing to the left of to the right. Else you get color changes to the depth.
[Q]



Looking at the 0.2.6 release. Could you point out where this is done in that code?
[Q]



thanks,
[Q]
Score: 0 points
Any particular reason?
#22626 by moonbeam (1.0000) posted on 9:03am Monday, June 16th, 2008
( no avatar )
dolfje said:
And for the 3d-spotlight, you have a strange glitch. The icon get white pixels next to the icon when it turns.
[Q]



all icons or just some icons?
[Q]
Score: 0 points
Any particular reason?
#22627 by dolfje (0.9832) posted on 9:14am Monday, June 16th, 2008
moonbeam said:
Looking at the 0.2.6 release. Could you point out where this is done in that code?
[Q]



libawn/awn-effect.c: r1506
[Q]




moonbeam said:
all icons or just some icons?
[Q]



I will have investigate it futher. I have it with the firefox icon with bar_height:31, but with a taller bar_height it is gone.
[Q]





*Edited at 10:01am, 06/16/08
Score: 0 points
Any particular reason?
#22628 by moonbeam (1.0000) posted on 9:33am Monday, June 16th, 2008
( no avatar )
dolfje said:
moonbeam said:
Looking at the 0.2.6 release. Could you point out where this is done in that code?
libawn/awn-effect.c: r1506
[Q]



Oddly that code is completely untouched.
[Q]



awn-effect-spotlightd3.c
[Q]



line 116
[Q]



so I'm guessing I might be missing something when fx->delta_width is dealt with in draw_icons. I'll look into that I guess.
[Q]
Score: 0 points
Any particular reason?
#22630 by mhr3 (0.9971) posted on 11:01am Monday, June 16th, 2008
moonbeam said:
Actually all I do is use cairo_scale to map the spotlight into whatever size surface I happen to be using so it just naturally centers (at least that's the theory).
[Q]



There's definitely a problem with it, I noticed it too, and the smaller "bar height" is used spotlight is nearer to left edge, and if "bar height" is very big spotlight is more to right.
[Q]

Score: 0 points
Any particular reason?
#22631 by moonbeam (1.0000) posted on 11:04am Monday, June 16th, 2008
( no avatar )
mhr3 said:
There's definitely a problem with it, I noticed it too, and the smaller "bar height" is used spotlight is nearer to left edge, and if "bar height" is very big spotlight is more to right.
[Q]



I'll have a look at it again. I just can't reproduce the issue here for some reason. Maybe it's a rounding issue.
[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 11:11am, 06/16/08
Score: 0 points
Any particular reason?
#22632 by moonbeam (1.0000) posted on 11:14am Monday, June 16th, 2008
( no avatar )
moonbeam said:
mhr3 said:
There's definitely a problem with it, I noticed it too, and the smaller "bar height" is used spotlight is nearer to left edge, and if "bar height" is very big spotlight is more to right.
[Q]



Ok... I'm seeing it with large values.
[Q]
Score: 0 points
Any particular reason?
#22633 by moonbeam (1.0000) posted on 11:48am Monday, June 16th, 2008
( no avatar )
I've pushed rev 292. I've test it with bar heights of 64 and 40. Got to run a few errands. So please give it a try.
[Q]



I think it's might still be off by a pixel or two. dunno really.
[Q]
Score: 0 points
Any particular reason?
#22634 by dolfje (0.9832) posted on 12:21pm Monday, June 16th, 2008
I think you try to calculate the middle by dividing the width of the icon by and use that. But the width of the space of the icon can be wider than the width of the icon. I'm trying to make a screencast of it, but my Istanbul recorder doens't work well.
[Q]

Score: 0 points
Any particular reason?
#22636 by moonbeam (1.0000) posted on 12:51pm Monday, June 16th, 2008
( no avatar )
When you test please use the following procedure.
[Q]



Load the awn notification daemon.
[Q]



set /apps/avant-window-navigator/applets/awn-notification-daemon/show_icon to true.
[Q]



There's a bit of bug in a-n-d icon code so please restart it after changing the bar size.
[Q]



This will give you a semi-transparent icon that fills the full icon dimensions.
[Q]



Thanks,
[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 12:54pm, 06/16/08
Score: 0 points
Any particular reason?
#22637 by dolfje (0.9832) posted on 2:42pm Monday, June 16th, 2008
I will test further tomorrow-night or the day after tomorrow. Because tomorrow I have an examination. Yoepi :(
[Q]

Score: 0 points
Any particular reason?
#22644 by moonbeam (1.0000) posted on 4:21pm Monday, June 16th, 2008
( no avatar )
dolfje said:
I will test further tomorrow-night or the day after tomorrow. Because tomorrow I have an examination. Yoepi :(
[Q]



Don't study too hard :-)
[Q]
Score: 0 points
Any particular reason?
#22645 by moonbeam (1.0000) posted on 10:25pm Monday, June 16th, 2008
( no avatar )
I did a bunch of changes tonight to get the depth code to fit in the cairo-effects framework. It's more or less done... but I think there's probably a bit of wobbling that needs to be fixed again. Tomorrow...
[Q]



I'll also deal with the occurrences of phantom pixels tomorrow.
[Q]



Still not sure how to deal with the flickering on the edges created by the depth routine....
[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 10:31pm, 06/16/08
Score: 0 points
Any particular reason?
#22646 by mhr3 (0.9971) posted on 10:20am Tuesday, June 17th, 2008
I think this is the correct fix for spotlight positioning:
[Q]



 

=== modified file 'libawn/awn-effects.c'
--- libawn/awn-effects.c 2008-06-17 04:59:00 +0000
+++ libawn/awn-effects.c 2008-06-17 17:15:36 +0000
@@ -617,8 +617,8 @@
spot_ctx = cairo_create(spot_srfc);
cairo_save(spot_ctx);
cairo_scale(spot_ctx,
- fx->icon_width / (double) gdk_pixbuf_get_width(SPOTLIGHT_PIXBUF)* 1.275,
- fx->icon_height / (double) gdk_pixbuf_get_height(SPOTLIGHT_PIXBUF)*1.2
+ fx->window_width / (double) gdk_pixbuf_get_width(SPOTLIGHT_PIXBUF),
+ fx->icon_height*5/4 / (double) gdk_pixbuf_get_height(SPOTLIGHT_PIXBUF)
);
cairo_set_source_surface(spot_ctx, cairo_get_target(unscaled_spot_ctx),
0.0, 0.0);
[Q]
  



[Q]
 



But there's another issue - spotlight is clipped, while is shouldn't be.
[Q]



*Edited at 10:21am, 06/17/08
Score: 0 points
Any particular reason?
#22647 by moonbeam (1.0000) posted on 10:28am Tuesday, June 17th, 2008
( no avatar )
mhr3 said:
I think this is the correct fix for spotlight positioning:
[Q]



Thanks. I'll try that out now.
[Q]
Score: 0 points
Any particular reason?
#22648 by moonbeam (1.0000) posted on 10:29am Tuesday, June 17th, 2008
( no avatar )
mhr3 said:
But there's another issue - spotlight is clipped, while is shouldn't be.
[Q]



The spotlight is to be placed in the full window (with padding) or just the icon space itself?
[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 11:00am, 06/17/08
Score: 0 points
Any particular reason?
#22649 by moonbeam (1.0000) posted on 11:15am Tuesday, June 17th, 2008
( no avatar )
mhr3 said:
I think this is the correct fix for spotlight positioning:
[Q]



Applied. r301
[Q]
Score: 0 points
Any particular reason?
#22650 by mhr3 (0.9971) posted on 11:21am Tuesday, June 17th, 2008
moonbeam said:
The spotlight is to be placed in the full window (with padding) or just the icon space itself?
[Q]



Well previously it was meant to cover full...
[Q]

Score: 0 points
Any particular reason?
#22651 by moonbeam (1.0000) posted on 11:53am Tuesday, June 17th, 2008
( no avatar )
mhr3 said:
Well previously it was meant to cover full...
[Q]



:-) I'll see what can be done about that
[Q]
Score: 0 points
Any particular reason?
#22652 by mhr3 (0.9971) posted on 12:03pm Tuesday, June 17th, 2008
moonbeam said:
:-) I'll see what can be done about that
[Q]



Now it works exactly as before, so I'd leave it as it is.
[Q]

Score: 0 points
Any particular reason?
#22653 by moonbeam (1.0000) posted on 12:04pm Tuesday, June 17th, 2008
( no avatar )
mhr3 said:
Now it works exactly as before, so I'd leave it as it is.
[Q]



Sounds like a good plan. Thanks.
[Q]
Score: 0 points
Any particular reason?
#22654 by moonbeam (1.0000) posted on 12:11pm Tuesday, June 17th, 2008
( no avatar )
Summarizing....
[Q]



At this point I'm still seeing:
[Q]



1) Flickering on the edges with the depth effect.
2) Pixel noise with certain icons (and possibly specific resolutons) seemingly due to the horizontal flip done with awn_effect_op_hflip(). The most visible example I've seen is with the icon that comes with malept's tweet applet (http://github.com/malept/tweet/tree/master ). This is visible with turn with, or without the depth enabled.
[Q]



Any other issues left?
[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 12:12pm, 06/17/08
Score: 0 points
Any particular reason?
#22662 by Timon (1.0000) posted on 2:03pm Tuesday, June 17th, 2008
It is probably not a good reason to add it to your branch, but for now I was running your branch of awn. I wrote a little patch that does expand the bar on the user's request (gconf setting). Maybe you could add that as well?
[Q]



Here it is:
[Q]



 

=== modified file 'libawn/awn-settings.c'
--- libawn/awn-settings.c 2008-06-16 17:35:00 +0000
+++ libawn/awn-settings.c 2008-06-17 18:13:59 +0000
@@ -38,6 +38,7 @@
#define ROUNDED_CORNERS "rounded_corners" /*bool*/
#define CORNER_RADIUS "corner_radius" /*float*/
#define RENDER_PATTERN "render_pattern" /*bool*/
+#define EXPAND_BAR "expand_bar" /*bool*/
#define PATTERN_URI "pattern_uri" /*string*/
#define PATTERN_ALPHA "pattern_alpha" /*float*/
#define GLASS_STEP_1 "glass_step_1" /*string*/
@@ -156,6 +157,7 @@
awn_load_bool(client, BAR, ROUNDED_CORNERS, &s->rounded_corners, TRUE);
awn_load_float(client, BAR, CORNER_RADIUS, &s->corner_radius, 10.0);
awn_load_bool(client, BAR, RENDER_PATTERN, &s->render_pattern, FALSE);
+ awn_load_bool(client, BAR, EXPAND_BAR, &s->expand_bar, FALSE);
awn_load_string(client, BAR, PATTERN_URI, &s->pattern_uri, "~");
awn_load_float(client, BAR, PATTERN_ALPHA, &s->pattern_alpha, 1.0);
[Q]
  



=== modified file 'libawn/awn-settings.h'
--- libawn/awn-settings.h 2008-06-16 17:35:00 +0000
+++ libawn/awn-settings.h 2008-06-17 18:12:21 +0000
@@ -62,6 +62,7 @@
gboolean rounded_corners;
gfloat corner_radius;
gboolean render_pattern;
+ gboolean expand_bar;
[Q]
  


gchar *pattern_uri;
gfloat pattern_alpha;
[Q]
  


=== modified file 'src/awn-bar.c'
--- src/awn-bar.c 2008-02-18 22:43:45 +0000
+++ src/awn-bar.c 2008-06-17 18:12:38 +0000
@@ -366,7 +366,12 @@
render (AwnBar *bar, cairo_t *cr, gint x_width, gint height)
{
AwnBarPrivate *priv = AWN_BAR_GET_PRIVATE (bar);
- gint width = current_width;
+ gint width;
+ if( settings->expand_bar ) {
+ width = settings->monitor.width;
+ } else {
+ width = current_width;
+ }
[Q]
  


height -= settings->icon_offset;
if( settings->bar_angle != 0 ) {
[Q]
  


[Q]
 



*Edited at 2:03pm, 06/17/08
Score: 0 points
Any particular reason?
#22663 by malept (1.0000) posted on 2:04pm Tuesday, June 17th, 2008
( no avatar )
Could you post the patch on the Awn bug tracker?
[Q]



Also, you should add the new option to the schema (data/awn.schema-ini).
[Q]

--
/
Score: 0 points
Any particular reason?
#22668 by davim (0.9996) posted on 5:00pm Tuesday, June 17th, 2008
@moonbeam You've been doing a great job on AWN lately :)
[Q]



thanks :D
[Q]

Score: 0 points
Any particular reason?
#22669 by moonbeam (1.0000) posted on 6:25pm Tuesday, June 17th, 2008
( no avatar )
Timon said:
It is probably not a good reason to add it to your branch, but for now I was running your branch of awn. I wrote a little patch that does expand the bar on the user's request (gconf setting). Maybe you could add that as well?
[Q]



Thanks. It looks straightforward enough. I'll give it a test sometime soon.
[Q]



But it makes things easier at release time if it's filed attached to a bug... and anything that makes our life easier is a good thing :-)
[Q]
Score: 0 points
Any particular reason?
#22670 by Timon (1.0000) posted on 3:28am Wednesday, June 18th, 2008
I (re)wrote the patch for Awn trunk and added it to launchpad:
https://bugs.launchpad.net/awn/+bug/240882
[Q]



It is exactly the same code, with the gconf key added to awn.schema-ini.in
[Q]



malept said:
Also, you should add the new option to the schema (data/awn.schema-ini).
[Q]

Score: 0 points
Any particular reason?
#22671 by dolfje (0.9832) posted on 7:13am Wednesday, June 18th, 2008
moonbeam said:
Any other issues left?
[Q]



I've scanned every icon effects bundle and I can't find any bugs (except the ones you mentioned in you post)
[Q]



great job ;)
[Q]



Score: 0 points
Any particular reason?
#22672 by moonbeam (1.0000) posted on 7:43am Wednesday, June 18th, 2008
( no avatar )
dolfje said:
I've scanned every icon effects bundle and I can't find any bugs (except the ones you mentioned in you post)
[Q]



Thanks. And thanks to everyone for the bug reports and fixes.
[Q]
Score: 0 points
Any particular reason?
#22677 by Photon (0.6711) posted on 11:54am Wednesday, June 18th, 2008
( no avatar )
Well, I don't know whether it has been mentioned above but I have a really strange behavior of the 3D Turn effect. The framerate seems not to be constant so on some points the rotation slows down and accelerates again. But it's a really old issue I was having before the merge of the cairo things, too. :)
[Q]

Score: 0 points
Any particular reason?
#22678 by some-guy (0.2646) posted on 12:07pm Wednesday, June 18th, 2008
I think that's a 'feature', but I'm not sure ;)
[Q]

--
"If it ain't broke, find something wrong with it"
Score: 0 points
Any particular reason?
#22679 by moonbeam (1.0000) posted on 12:23pm Wednesday, June 18th, 2008
( no avatar )
Photon said:
Well, I don't know whether it has been mentioned above but I have a really strange behavior of the 3D Turn effect. The framerate seems not to be constant so on some points the rotation slows down and accelerates again. But it's a really old issue I was having before the merge of the cairo things, too. :)
[Q]



Yeah I haven't touched that side of the code.... and if all goes well I won't need to. I actually think there are people who are much better qualified to develop actual effects than I am :-) I'd just like to broaden the tools available.
[Q]
Score: 0 points
Any particular reason?
#22680 by Photon (0.6711) posted on 12:38pm Wednesday, June 18th, 2008
( no avatar )
Oh well, than I'll wait till someone of the effects developers fixes this. :)
[Q]

Score: 0 points
Any particular reason?
#22681 by mhr3 (0.9971) posted on 2:06pm Wednesday, June 18th, 2008
Photon said:
Oh well, than I'll wait till someone of the effects developers fixes this. :)
[Q]



As some-guy said, it's a feature, it doesn't look that good with constant rotation speed. ;)
[Q]

Score: 0 points
Any particular reason?
#22708 by moonbeam (1.0000) posted on 12:37pm Saturday, June 21st, 2008
( no avatar )
I'd like to note that I haven't abandoned the two bugs listed above.
[Q]



However, it seems that they might not be happening on all systems (example being njpatel who doesn't seem to be experiencing them)/
[Q]



Anyone who is having the issue... could you please post your video card, video card driver and version of cairo?
[Q]



I'm going to try and record the problem with edges... but desktop recording software tends to cooperate with my system to well.
[Q]



I will post some stills of the pixel issue in the next post.
[Q]
Score: 0 points
Any particular reason?
#22709 by moonbeam (1.0000) posted on 12:40pm Saturday, June 21st, 2008
( no avatar )
pixel bug:
[Q]



Using the current twitter applet icon (expect it to be changing soon). Bar height 42 (I believe).
[Q]



[Q]




[Q]

--
http://moon-shiny.blogspot.com/

*Edited at 12:42pm, 06/21/08
Score: 0 points
Any particular reason?
#23764 by mhr3 (0.9971) posted on 8:57am Tuesday, August 26th, 2008
Hey moonbeam, please take a look at video I made: http://www.mediafire.com/?qf7mi9q56gi
[Q]



I think there's an issue with reflections alpha, if you look closely the reflections' alpha behaves differently on applets than it does on taskmanager - for some reason it seems that it's higher on applets than it is on taskmanager.
[Q]



This is easily visible when using the hover effect, because on the end of the animation the reflection flickers to much higher alpha, but it should stay low as it is seen on the taskmanager icons.
[Q]



Hope you get what I mean. :)
[Q]



*Edited at 9:30am, 08/26/08
Score: 0 points
Any particular reason?
#23767 by moonbeam (1.0000) posted on 9:14am Tuesday, August 26th, 2008
( no avatar )
mhr3 said:
Hope you get what I mean. :)
[Q]



I think I see what you mean. Could you test with exactly the same icon for the launcher as the applet.
[Q]



I'll probably be installing the 0.2.7 to do some testing tonight so I can look at it then if the same icon test still shows the problem. At the moment I'm running the rewrite which doesn't allow me to test here.
[Q]
Score: 0 points
Any particular reason?
#23770 by mhr3 (0.9971) posted on 9:28am Tuesday, August 26th, 2008
moonbeam said:
I think I see what you mean. Could you test with exactly the same icon for the launcher as the applet.
[Q]






*Edited at 9:30am, 08/26/08
Score: 0 points
Any particular reason?
#23774 by moonbeam (1.0000) posted on 12:42pm Tuesday, August 26th, 2008
( no avatar )



Thanks. I'll try and look into it tonight.
[Q]



Out of curiosity do you is config key app/icon_alpha ?
[Q]



I think this will be interesting to track down.
[Q]
Score: 0 points
Any particular reason?
#23784 by mhr3 (0.9971) posted on 2:12am Wednesday, August 27th, 2008
moonbeam said:
Out of curiosity do you is config key app/icon_alpha ?
[Q]



 



[Q]
 

Score: 0 points
Any particular reason?
#23796 by moonbeam (1.0000) posted on 5:44pm Wednesday, August 27th, 2008
( no avatar )
mhr3,
[Q]



Ok... you always find the fun ones. :-)
[Q]



I'd like to confirm whether the "task" icon is an actual task icon or if it is a launcher?
[Q]



Also do you have the draw arrow config option enabled?
[Q]



thanks,
[Q]
Score: 0 points
Any particular reason?
#23797 by mhr3 (0.9971) posted on 12:51am Thursday, August 28th, 2008
moonbeam said:
I'd like to confirm whether the "task" icon is an actual task icon or if it is a launcher?
[Q]



It's a task icon, but launchers behave the same way (correctly), only applets don't.
[Q]



moonbeam said:
Also do you have the draw arrow config option enabled?
[Q]



You mean "tasks_have_arrows"? No that's disabled, here's my whole app gconf tree > http://pastebin.com/m49e10577
[Q]

Score: 0 points
Any particular reason?
#23798 by mhr3 (0.9971) posted on 12:59am Thursday, August 28th, 2008
Ah, I just figured out what's the problem - it's the reflection_alpha_multiplier key, for some reason taskmanager/launcher doesn't respect the value at all, while applets do. And the glow animation effect doesn't take this key into consideration, that's why I'm seeing alpha flicker at the end of the animation - easily visible if you set the key to 1.
[Q]



Sounds like it needs fixing on multiple places - first in taskmanager to respect it and then the animation alone (well any animations which deal with reflection alpha).
[Q]

Score: 0 points
Any particular reason?
#23799 by moonbeam (1.0000) posted on 7:21am Thursday, August 28th, 2008
( no avatar )
mhr3 said:
Ah, I just figured out what's the problem - it's the reflection_alpha_multiplier key, for some reason taskmanager/launcher doesn't respect the value at all, while applets do. And the glow animation effect doesn't take this key into consideration, that's why I'm seeing alpha flicker at the end of the animation - easily visible if you set the key to 1.
[Q]



ok. well that narrows things down a bit.
[Q]



thanks,
[Q]
Score: 0 points
Any particular reason?
Pages: 1 2
Thread Listing » General AWN Discussion » [Announcement] New experimental branch awn-cairo-effects

Post A Reply:

Powered by Metaforum ©2004-2012
Get your own Free AJAX Forum Messageboard by visiting the offical site.
.